Template talk:VideoGallery/sandbox: Difference between revisions

m
Line 15: Line 15:
::Yeah, I'm mostly satisfied with the current sandbox considering my limited abilities. It could be better optimized and issues could be sorted out in no added complexity hopefully. I'm glad there aren't any bigger issues. [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 02:47, 31 January 2018 (CET)
::Yeah, I'm mostly satisfied with the current sandbox considering my limited abilities. It could be better optimized and issues could be sorted out in no added complexity hopefully. I'm glad there aren't any bigger issues. [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 02:47, 31 January 2018 (CET)
:::I think it's fine honestly, besides the pedantic formatting stuff. I didn't even know you could use a variable within a regex string, so that's cool. I'd have to really sit down with a pen and paper and do the math on the random logic in there to have any comment on it, and I haven't yet. My only gripe is that the template should skip over the legacy version if <nowiki>{{{1|}}}</nowiki> is defined, but that would hurt how nicely they're split up currently. - [[User:Xerxes|Xerxes]] ([[User talk:Xerxes|talk]]) 05:59, 31 January 2018 (CET)
:::I think it's fine honestly, besides the pedantic formatting stuff. I didn't even know you could use a variable within a regex string, so that's cool. I'd have to really sit down with a pen and paper and do the math on the random logic in there to have any comment on it, and I haven't yet. My only gripe is that the template should skip over the legacy version if <nowiki>{{{1|}}}</nowiki> is defined, but that would hurt how nicely they're split up currently. - [[User:Xerxes|Xerxes]] ([[User talk:Xerxes|talk]]) 05:59, 31 January 2018 (CET)
:::: Okay! I know the code in template is getting quite complicated, it took time for me to understand which code is responsible for what went wrong in live page. I've explored through potential workarounds, looked on internet for examples and lot of guess, then lot of edit previews and lately, things work out fine. I feel accomplished. NOW it'd be hard for people other than me to understand how they work unless they study lot on it! Haha! Anyway, I was thinking of keeping the legacy version just in case we've had to work through the existing videos those that have not adapted to the new format yet. Then if all the videos are converted into new format then the legacy codes can be purged out. Or we can just ask Kolano or someone else mass edit and convert the existing videos to new format, and if they will, the legacy codes can be dropped beforehand. [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 07:17, 31 January 2018 (CET)


* #vardefineecho: Would be preferable to not have it, but shouldn't be a big problem.
* #vardefineecho: Would be preferable to not have it, but shouldn't be a big problem.
Line 26: Line 27:
:::::All the empty videogalleries were copy/pasted, so regex replacing only those ones to add the echo should be alright. (Though we could've just regex'd everything to begin with, but don't tell anyone I said that.) - [[User:Xerxes|Xerxes]] ([[User talk:Xerxes|talk]]) 04:16, 31 January 2018 (CET)
:::::All the empty videogalleries were copy/pasted, so regex replacing only those ones to add the echo should be alright. (Though we could've just regex'd everything to begin with, but don't tell anyone I said that.) - [[User:Xerxes|Xerxes]] ([[User talk:Xerxes|talk]]) 04:16, 31 January 2018 (CET)
:::::I'd guess it probably wouldn't be too hard to work out regex to convert the old parameter format to the new one. I have some concerns over having a mixed bag of formats. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 06:22, 31 January 2018 (CET)
:::::I'd guess it probably wouldn't be too hard to work out regex to convert the old parameter format to the new one. I have some concerns over having a mixed bag of formats. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 06:22, 31 January 2018 (CET)
::::::Multiple regex mass edit could work out. I just can't think of what regex that will add #vardefineecho: and then convert between old and new format in one go. [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 07:17, 31 January 2018 (CET)
::Also, like sandbox, VideoGallery never had the list in random order, just the featured videos. [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 02:47, 31 January 2018 (CET)
::Also, like sandbox, VideoGallery never had the list in random order, just the featured videos. [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 02:47, 31 January 2018 (CET)


Okay, thanks, I've now not looking at cons or issues as true problematic, I've moved them to [[Template:VideoGallery/sandbox#Quirks]] except I think #vardefineecho: is still a con. I don't think I'm going to treat double open bracket as con of this template, it's an outside problem. [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 03:49, 31 January 2018 (CET)
Okay, thanks, I've now not looking at cons or issues as true problematic, I've moved them to [[Template:VideoGallery/sandbox#Quirks]] except I think #vardefineecho: is still a con. I don't think I'm going to treat double open bracket as con of this template, it's an outside problem. [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 03:49, 31 January 2018 (CET)
6,576

edits