15,198
edits
Template talk:Problems: Difference between revisions
Username rename (Jhonn => mbc07)
(Username rename (Jhonn => mbc07)) |
|||
| Line 4: | Line 4: | ||
: I added an equals template {{tl|{{=}}}} to work around the problem, unclear if there is any better way of handling it. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 01:16, 4 December 2016 (CET) | : I added an equals template {{tl|{{=}}}} to work around the problem, unclear if there is any better way of handling it. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 01:16, 4 December 2016 (CET) | ||
:: I'll investigate this, probably an edge-case with the RegExp queries... - [[User: | :: I'll investigate this, probably an edge-case with the RegExp queries... - [[User:mbc07|mbc07]] ([[User talk:mbc07|talk]]) 01:22, 4 December 2016 (CET) | ||
::: It seems to be a template parameter parsing issue, unclear if there is anyway to escape them to avoid needing the template I added. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 01:33, 4 December 2016 (CET) | ::: It seems to be a template parameter parsing issue, unclear if there is anyway to escape them to avoid needing the template I added. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 01:33, 4 December 2016 (CET) | ||
| Line 10: | Line 10: | ||
::: Also unclear if there is any current way to search for/flag problems effected by this. Problems with external links, and some settings references (i.e. XFB=Real), are likely candidates to cause problems. The old search-n-replace had allowed for regex searches, but I think we lost that with the newly implemented one (I've forgotten the details). [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 03:31, 4 December 2016 (CET) | ::: Also unclear if there is any current way to search for/flag problems effected by this. Problems with external links, and some settings references (i.e. XFB=Real), are likely candidates to cause problems. The old search-n-replace had allowed for regex searches, but I think we lost that with the newly implemented one (I've forgotten the details). [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 03:31, 4 December 2016 (CET) | ||
:::: Okay, the issue is trickier than I though. I double checked all RegExp queries and they all are working as intended, the issue here is the parameter's parsing. Basically, by having a = in those cases is making the problems "text" being passed as an argument different than {{{1}}}, so, the problems never get into the template logic (since it checks for {{{1}}}, and when the bug is triggered, {{{1}}} is empty). The strange part is that the various === from the headings doesn't trigger this bug, yet a forum link like the one from [[Homebrew Channel]] does. I'll see if I can do something to somehow prevent that, but at the moment there's no fix other than the workaround you provided... - [[User: | :::: Okay, the issue is trickier than I though. I double checked all RegExp queries and they all are working as intended, the issue here is the parameter's parsing. Basically, by having a = in those cases is making the problems "text" being passed as an argument different than {{{1}}}, so, the problems never get into the template logic (since it checks for {{{1}}}, and when the bug is triggered, {{{1}}} is empty). The strange part is that the various === from the headings doesn't trigger this bug, yet a forum link like the one from [[Homebrew Channel]] does. I'll see if I can do something to somehow prevent that, but at the moment there's no fix other than the workaround you provided... - [[User:mbc07|mbc07]] ([[User talk:mbc07|talk]]) 05:06, 4 December 2016 (CET) | ||
::::: Since it doesn't seem like it can be corrected, I'd like to focus on identifying pages where it occurs. Can we trigger a category when an unexpected param is provided to the {{tl|Problems}} template? [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 11:47, 4 December 2016 (CET) | ::::: Since it doesn't seem like it can be corrected, I'd like to focus on identifying pages where it occurs. Can we trigger a category when an unexpected param is provided to the {{tl|Problems}} template? [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 11:47, 4 December 2016 (CET) | ||
:::::: Sure, I'll see what can I do - [[User: | :::::: Sure, I'll see what can I do - [[User:mbc07|mbc07]] ([[User talk:mbc07|talk]]) 17:27, 4 December 2016 (CET) | ||
:::::: Take a look at the recent edit I made in [[Homebrew Channel]]. It avoids the issue completely, although it also makes template usage a bit more "messy". What do you think? - [[User: | :::::: Take a look at the recent edit I made in [[Homebrew Channel]]. It avoids the issue completely, although it also makes template usage a bit more "messy". What do you think? - [[User:mbc07|mbc07]] ([[User talk:mbc07|talk]]) 17:46, 4 December 2016 (CET) | ||
::::::: Not sure. I guess it's not too bad once we'd use the search-n-replace to populate it everywhere so users wouldn't have to remember, but it is a bit ugly. I guess that logic has to exist outside the template itself? It's certainly preferable to having users needing to remember to escape any equals characters though, so I'm supportive either way. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 20:43, 4 December 2016 (CET) | ::::::: Not sure. I guess it's not too bad once we'd use the search-n-replace to populate it everywhere so users wouldn't have to remember, but it is a bit ugly. I guess that logic has to exist outside the template itself? It's certainly preferable to having users needing to remember to escape any equals characters though, so I'm supportive either way. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 20:43, 4 December 2016 (CET) | ||
:::::::: Yes, it must be outside of the template. It's basically assigning a variable with the text before passing it to the template, and it avoids the issue because = has no special meaning when defining a variable. The content of the variable is then "echoed" into the template parameter {{{1}}}, avoiding it wrongly recognizing = as a definition of a specific parameter. Another possible approach is using <tt><nowiki>{{#vardefine:problems| <problems text here> }}{{Problems}}</nowiki></tt> then refactoring {{tl|Problems}} to work directly on that variable instead of the {{{1}}} parameter, but it still looks a bit messy. What do you think, does it look better? - [[User: | :::::::: Yes, it must be outside of the template. It's basically assigning a variable with the text before passing it to the template, and it avoids the issue because = has no special meaning when defining a variable. The content of the variable is then "echoed" into the template parameter {{{1}}}, avoiding it wrongly recognizing = as a definition of a specific parameter. Another possible approach is using <tt><nowiki>{{#vardefine:problems| <problems text here> }}{{Problems}}</nowiki></tt> then refactoring {{tl|Problems}} to work directly on that variable instead of the {{{1}}} parameter, but it still looks a bit messy. What do you think, does it look better? - [[User:mbc07|mbc07]] ([[User talk:mbc07|talk]]) 01:55, 5 December 2016 (CET) | ||
::::::::: If it can't be embedded it doesn't really matter, the initial nested handling is probably easier to understand. So my vote would be to search-n-replace away with the initial handling.[[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 04:12, 5 December 2016 (CET) | ::::::::: If it can't be embedded it doesn't really matter, the initial nested handling is probably easier to understand. So my vote would be to search-n-replace away with the initial handling.[[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 04:12, 5 December 2016 (CET) | ||
:::::::::: Alright, nested handling then. I'm a bit busy but if everything goes well I'll start the batch replace with the fix in a few hours... - [[User: | :::::::::: Alright, nested handling then. I'm a bit busy but if everything goes well I'll start the batch replace with the fix in a few hours... - [[User:mbc07|mbc07]] ([[User talk:mbc07|talk]]) 07:00, 6 December 2016 (CET) | ||
== Template Request == | == Template Request == | ||
| Line 63: | Line 63: | ||
**[[Just Dance]] (series?, ug, this series needs further review common problems don't seem spread around properly) | **[[Just Dance]] (series?, ug, this series needs further review common problems don't seem spread around properly) | ||
::<s>I have all games from the main series and some spin offs and from personal experience we can safely split them between first gen (Just Dance 1/2/3/4, ABBA You Can Dance, Michael Jackson The Experience) and second gen (Just Dance 2014/2015/2016 and onwards). All first gen titles have video corruption issues due to filtering enhancements. Second gen titles doesn't suffer from filtering issues but works only with wiispeak branch (or Ishiiruka) and requires EFB2RAM to properly display characters in many songs. Just Dance Wii and Just Dance Wii 2 are also first gen titles (based on Just Dance 2/Just Dance 3, respectively), can't say anything about Just Dance Kids or other spin offs like Dance on Broadway... </s> | ::<s>I have all games from the main series and some spin offs and from personal experience we can safely split them between first gen (Just Dance 1/2/3/4, ABBA You Can Dance, Michael Jackson The Experience) and second gen (Just Dance 2014/2015/2016 and onwards). All first gen titles have video corruption issues due to filtering enhancements. Second gen titles doesn't suffer from filtering issues but works only with wiispeak branch (or Ishiiruka) and requires EFB2RAM to properly display characters in many songs. Just Dance Wii and Just Dance Wii 2 are also first gen titles (based on Just Dance 2/Just Dance 3, respectively), can't say anything about Just Dance Kids or other spin offs like Dance on Broadway... </s> | ||
::After 5.0 stable and recent builds, everything is fixed on the newer Just Dance games. The only common problem is probably worth creating a template is for the Filtering issue on Just Dance 1/2/3/4 (but I suspect it might be already fixed in a PR opened recently which improves EFB2RAM Copy downscaling filter -- haven't tested it, though) - [[User: | ::After 5.0 stable and recent builds, everything is fixed on the newer Just Dance games. The only common problem is probably worth creating a template is for the Filtering issue on Just Dance 1/2/3/4 (but I suspect it might be already fixed in a PR opened recently which improves EFB2RAM Copy downscaling filter -- haven't tested it, though) - [[User:mbc07|mbc07]] ([[User talk:mbc07|talk]]) 19:33, 7 September 2016 (CEST) | ||
*All the VP6 titles | *All the VP6 titles | ||
**[[MySims SkyHeroes]] | **[[MySims SkyHeroes]] | ||
| Line 147: | Line 147: | ||
== Black Bars == | == Black Bars == | ||
As is apparently common with GameCube titles this game adds black bars around the edges of the screen to avoid gameplay being covered by television bezels. Figured we should probably have a common {{tl|Problems}} template for such, but want to get some further details first. How it works seems to be a bit odd, at least for this title. Here I get black bars at startup (in 4:3 mode) and all the time if in fullscreen mode, but if in windowed mode /w Auto AR and Auto Adjust Window Size no side black bars are seen. In any case hoping someone can chime in regarding some of the details with titles and black bar edges. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 05:54, 2 December 2015 (CET) | As is apparently common with GameCube titles this game adds black bars around the edges of the screen to avoid gameplay being covered by television bezels. Figured we should probably have a common {{tl|Problems}} template for such, but want to get some further details first. How it works seems to be a bit odd, at least for this title. Here I get black bars at startup (in 4:3 mode) and all the time if in fullscreen mode, but if in windowed mode /w Auto AR and Auto Adjust Window Size no side black bars are seen. In any case hoping someone can chime in regarding some of the details with titles and black bar edges. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 05:54, 2 December 2015 (CET) | ||
: AFAIK enabling "Crop" option in Graphics settings should get rid of those black bars in recent revisions. Have you tried it? - [[User: | : AFAIK enabling "Crop" option in Graphics settings should get rid of those black bars in recent revisions. Have you tried it? - [[User:mbc07|mbc07]] ([[User talk:mbc07|talk]]) 16:32, 2 December 2015 (CET) | ||
::Noticed that last night, but didn't have a chance to try it. How "smart" is the cropping? Different titles left a variety of different sized gaps; some only on one pair of sides, some even allowing fine grained control over their coverage area. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 22:57, 2 December 2015 (CET) | ::Noticed that last night, but didn't have a chance to try it. How "smart" is the cropping? Different titles left a variety of different sized gaps; some only on one pair of sides, some even allowing fine grained control over their coverage area. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 22:57, 2 December 2015 (CET) | ||
:::Perfectly smart! [https://dolphin-emu.org/blog/2015/08/01/dolphin-progress-report-july-2015/#40-7138-pixel-aspect-ratio-adjustment-vi-scaling-fix-by-mirrorbender Described in a progress report here] To poorly describe how phire put it when he told me about it, it uses the area that the game tells the hardware it will render to within the rendering space. It will eliminate all black bars, period! And it does it by zooming in, instead of the old squishing method (which can be achieved by using stretch to window). - [[User:MaJoR|MaJoR]] ([[User talk:MaJoR|talk]]) 12:27, 3 December 2015 (CET) | :::Perfectly smart! [https://dolphin-emu.org/blog/2015/08/01/dolphin-progress-report-july-2015/#40-7138-pixel-aspect-ratio-adjustment-vi-scaling-fix-by-mirrorbender Described in a progress report here] To poorly describe how phire put it when he told me about it, it uses the area that the game tells the hardware it will render to within the rendering space. It will eliminate all black bars, period! And it does it by zooming in, instead of the old squishing method (which can be achieved by using stretch to window). - [[User:MaJoR|MaJoR]] ([[User talk:MaJoR|talk]]) 12:27, 3 December 2015 (CET) | ||