15,188
edits
Template talk:Ratings: Difference between revisions
m
→Lucario's recent changes
| Line 4: | Line 4: | ||
:I only disliked removing the category, not the changes to the actual template. I think the template change to visually distinguish zero stars from misformatted rating is fine, and it looks nice. And really, we do actually have all the game pages completed (as far as we know), and the error category is empty, so removing it isn't a disaster or anything. Though it's probably still a good idea to keep it and other error categories in case pages get edited or moved (or added, though unlikely) in the future. - [[User:Xerxes|Xerxes]] ([[User talk:Xerxes|talk]]) 01:59, 9 June 2020 (CEST) | :I only disliked removing the category, not the changes to the actual template. I think the template change to visually distinguish zero stars from misformatted rating is fine, and it looks nice. And really, we do actually have all the game pages completed (as far as we know), and the error category is empty, so removing it isn't a disaster or anything. Though it's probably still a good idea to keep it and other error categories in case pages get edited or moved (or added, though unlikely) in the future. - [[User:Xerxes|Xerxes]] ([[User talk:Xerxes|talk]]) 01:59, 9 June 2020 (CEST) | ||
: I'm neutral on the visual distinguishing, but I'm 100% against removing the category. Yes, all pages have proper ratings right now, but I strongly think all maintenance categories (not just this one) should stay as they're arguably the quickest way to detect any breaking change that might have been done on other wiki pages, since they're auto populated by the wiki templates and extensions themselves. Also, it's not written in stone but any major change (especially feature removals) made to "deployed" templates should go into sandbox pages for review first, like we always used to do here. It's true we don't have a lot of active wiki maintainers nowadays but that's definitely no excuse to simply skip the review | : I'm neutral on the visual distinguishing, but I'm 100% against removing the category. Yes, all pages have proper ratings right now, but I strongly think all maintenance categories (not just this one) should stay as they're arguably the quickest way to detect any breaking change that might have been done on other wiki pages, since they're auto populated by the wiki templates and extensions themselves. Also, it's not written in stone but any major change (especially feature removals) made to "deployed" templates should go into sandbox pages for review first, like we always used to do here. It's true we don't have a lot of active wiki maintainers nowadays but that's definitely no excuse to simply skip the review phase and straight out implement changes like that directly on the main templates out of the blue - [[User:mbc07|mbc07]] ([[User talk:mbc07|talk]]) 08:18, 9 June 2020 (CEST) | ||
== Nonerror parameter necessary? == | == Nonerror parameter necessary? == | ||