Template talk:Testing: Difference between revisions

No edit summary
Line 64: Line 64:


::::I'm not sure this will work out. Try using the "Collapse" button, it seems to cause the full table to disappear now. Didn't investigate further to try to see why. Perhaps you just missed pulling in one of the relevant classes here, but I'm not sure.  [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 18:54, 6 December 2015 (CET)
::::I'm not sure this will work out. Try using the "Collapse" button, it seems to cause the full table to disappear now. Didn't investigate further to try to see why. Perhaps you just missed pulling in one of the relevant classes here, but I'm not sure.  [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 18:54, 6 December 2015 (CET)
:::::When implemented it'll work fine without breaking any functionality we currently have, this table from the example I put above isn't actually calling {{tl|Testing/entry}} <s>and I was too lazy to actually check and include all required classes</s> (fixed, should mimic {{tl|Testing}} correctly now). I want to hear about possible points you may have in favour/against of this approach before moving further (and if possible, address possible complaints)... - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 19:23, 6 December 2015 (CET)
:::::When implemented it'll work fine without breaking any functionality we currently have, this table from the example I put above isn't actually calling {{tl|Testing/entry}} <s>and I was too lazy to actually check and include all required classes</s> (fixed, should mimic {{tl|Testing}} correctly now). I want to hear about possible points you may have in favour/against of this approach before moving further (and if possible, address possible complaints)... - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 19:23, 6 December 2015 (CET)
::::::I was just worried we'd break the collapse when using colspans somehow. Still seems to be funny if the sort buttons are used, so we may need to watch out for breakage if implemented. Only other concern I have is that we then label the Device column as CPU\GPU, but that's probably not the end of the world. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 02:13, 7 December 2015 (CET)