Template talk:Testing/entry: Difference between revisions

Line 27: Line 27:


OK, now have this in place [[Template:Testing/entry/sandbox/testcases|in the sandbox]]. Please let me know your thoughts. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 02:02, 21 November 2015 (CET)
OK, now have this in place [[Template:Testing/entry/sandbox/testcases|in the sandbox]]. Please let me know your thoughts. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 02:02, 21 November 2015 (CET)
: The concept is very clever, I really like it, but I feel the current implementation, while working as intended, could be a little simpler:
:* Check if <nowiki>{{VersionRevision|{{{revision|}}}}}</nowiki> is bigger or equal than <nowiki>{{#var:tl_testing_entry_lastrev|0}}</nowiki> (will automatically return 0 if it's the first entry).
::*If true, set tl_testing_entry_lastrev to <nowiki>{{VersionRevision|{{{revision|}}}}}</nowiki>
::*If false, tag the page with the unordered category (and possibly set a flag to avoid reincluding the category again if already included, similar to {{tl|s}}).
: The whole logic can be done in a single <nowiki>{{#ifexpr}}</nowiki> that way! But independent of that, it looks really good to me, +1 for merging it in the main template! - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]])