Project:General Discussions/Archive: Difference between revisions

Jump to navigation Jump to search
Line 1,033: Line 1,033:


Please feel free to move forward with this. I've known it's needed for a while, but had been holding off on it till a more complete set of title pages was in place. Though some progress has been made there, that may take another year or more to complete, so perhaps we don't want to wait. Uniform character spacing should be nearly universal, outside of perhaps a few oddball browsers/platforms lacking appropriate monospaced fonts. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 19:38, 25 November 2016 (CET)
Please feel free to move forward with this. I've known it's needed for a while, but had been holding off on it till a more complete set of title pages was in place. Though some progress has been made there, that may take another year or more to complete, so perhaps we don't want to wait. Uniform character spacing should be nearly universal, outside of perhaps a few oddball browsers/platforms lacking appropriate monospaced fonts. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 19:38, 25 November 2016 (CET)
=== Problems section automation ===
Okay, that's something that bothered me for a long time but I couldn't find a "good" way to address, at least until now. Basically, the Problems section exists on all game pages, but on games without any problem, it's just an empty section without any information (that bothers me), and when it have problems it's not always correctly flagged in [[:Category:Pages with active problems]] or [[:Category:Pages with fixed problems]] because it relies on {{tl|issue}} or {{tl|s}} being called somewhere in the page, which isn't always the case.
After some tinkering, I think I found a good way to address those points without making things complicated. It's actually using the new {{tl|Problems}} template I just made. Similar to {{tl|Config}}, it takes the input then handle it accordingly. I also made the usage as simple as possible, take the example below (this is how the problems section looks like nowadays):
<pre>
== Problems ==
=== Problem 1 ===
Game XXX has an issue when using save states, which will corrupt your save file.
{{Problems/VP6 Videos}}
=== {{s}}Fixed Problem 2{{/s}} ===
Game XXX will display corrupted graphics when using EFB2Tex, use EFB2RAM to avoid that. Fixed in {{revision|5.0-1000}}.
</pre>
To use {{tl|Problems}}, the modification in the page is pretty small. For example, that's how it would look:
<pre>
== Problems ==
{{Problems|
=== Problem 1 ===
Game XXX has an issue when using save states, which will corrupt your save file.
{{Problems/VP6 Videos}}
=== <s>Fixed Problem 2</s> ===
Game XXX will display corrupted graphics when using EFB2Tex, use EFB2RAM to avoid that. Fixed in {{revision|5.0-1000}}.
}}
</pre>
The call to {{tl|Problems}} should be added into every game page (and well, we have MassEditRegex in our favour) and it has the following advantages:
* It deprecates {{tl|s}} and {{tl|/s}} and also the workaround currently implemented in {{tl|issue}} templates. It also somewhat achieves the same goals of the experimental {{tl|Active}} and {{tl|Fixed}} templates, so, 4 less templates to maintain and one workaround dropped.
* Similar to Config section, it provides a nice "Currently there's no known problems with this game." text on pages without any problem entries (that's something I always wanted to have).
* It accurately flags pages under [[:Category:Pages with active problems]] or [[:Category:Pages with fixed problems]] without depending of external templates and correctly track even active problems without an issue link (something we currently don't track).
* It also flags pages with potentially misformatted entries (e.g. the problems section is not empty and did not get flagged in any of the active or fixed problems categories).
* From my preliminary testing, it works without issues with any of the {{tl|Problems}} subtemplates as well.
* You can also use the <tt>type=</tt> parameter to better reflect the page type (e.g. channel pages). This parameter is optional and works exactly like the <tt>type=</tt> parameter from {{tl|Config}}.
And well, there's a single disadvantage, but given the benefits I think it's perfectly doable: the "[edit]" button disappears from the individual entries, but you can still find it under the main "Problems" section. So, given the benefits, I almost started implementing this everywhere, but it's a somewhat big change, so I would like to hear any thoughts you guys might have before starting (especially from [[User:Kolano]] and [[User:MaJoR]]). - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 07:56, 19 November 2016 (CET)
: The missing edit buttons are deficit. That will likely require looking at each specific Problem edit to tell what was revised (i.e. since section titles won't appear in the Recent Changes list). I'm supportive of this though, since I'd like to see the Active Problems functionality restored. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 20:09, 19 November 2016 (CET)
: Going to try it out on a few pages so we can get a feel for how it works, presuming it works well enough to not bother with sandbox pages...
:*[[Harry Potter and the Prisoner of Azkaban]] ([https://wiki.dolphin-emu.org/index.php?title=Harry_Potter_and_the_Prisoner_of_Azkaban&oldid=126383 /wo template]
:*[[The Price Is Right 2010 Edition]] ([https://wiki.dolphin-emu.org/index.php?title=The_Price_Is_Right_2010_Edition&oldid=124728 /wo template]
:...Price is Right shows it successfully adding to [[:Category:Pages with active problems]] category without an embedded {{tl|Issue}}. Would be nice if some extra parsing could allow flagging such (i.e. problems /wo issues).
:[[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 02:21, 20 November 2016 (CET)
:: Do we want to pull the Problems heading into the template as well. We already do so for the Problems subtemplates. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 03:01, 20 November 2016 (CET)
::: I particularly don't. I intentionally left the main "Problems" heading out of the template so we can get the "[edit]" button on it at least (e.g. similar to config template). If we insert it into the template the button will be gone and so edits in the problems section would be less obvious on [[Special:RecentChanges]], outsiders might not understand why the other sections have edit buttons while Problems doesn't, etc etc. Regarding flagging pages with active problems but without issues, <s>I think it's doable by using #varfinal, I'll try to get that working</s> Seems more tricky than I thought, but I think I can still find a way to do this by messing with RegExp capture groups, stay tuned - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 04:09, 20 November 2016 (CET)
::: I agree with Jhonn, it'd be less consistent with other heading 2 sections (== text ==) and thus will confuse the editors. I'm perfectly fine with heading 3 sections (=== text ===) to not have edit button, that will be great for edit summary too, we don't need to see some obscure problem name but something we're very familiarized with, "Problems". [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 05:40, 20 November 2016 (CET)
:Compared to [[Template:Active]] and [[Template:Fixed]], this will provide text that there's no known problems to the Problems section with empty contents. It also doesn't require use the same templates constantly for the multiple problems. There are downsides against [[Template:Problems]] too but I'm gonna refrain from saying it. [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 05:40, 20 November 2016 (CET)
Okay, it's done. Flagging pages with active problems but without issue links was harder than I though but it's now implemented. Basically it does a RegExp query to find how many active problems the page has (it does that by "counting" level 3 headings without <nowiki><s></s></nowiki>) and after that it loops through the text of each "active" heading it found earlier querying for "<nowiki>[https://dolp.in/i<number>]</nowiki>" (it wasn't possible to search for {{tl|issue}} calls directly because the template was parsed before the RegExp query). Although it currently does that lookup only on active problems, I left in the template some "base" code enabling us to do the same with fixed problems as well, if we need (maybe tagging pages with fixed problems without a revision link? Not sure if that is useful but it's that kind of thing which is possible to do). TL;DR, it outputs a nice text saying there are no problems if the section is empty and accurately flag pages under [[:Category:Pages with active problems]], [[:Category:Pages with fixed problems]], [[:Category:Pages with active problems missing issue links]] or [[:Category:Pages with misformatted problems]] without needing additional templates like {{tl|s}}, {{tl|/s}}, {{tl|active}} and {{tl|fixed}} or the workaround in {{tl|issue}}. If there's nothing more you guys want to ask or to add on {{tl|Problems}}, I'll start implementing it on all pages... - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 06:40, 23 November 2016 (CET)
:One more thing, do you think we should do something with Global Problems section as well? It'd be abnormal to read the Problems template saying there's no problems with a game although there is one or several right under Global Problems section. If we're gonna integrate the Global Problems section into this Problems template we'd have to include the heading 2 section "Problems" too, this will sacrifice the Edit button however. I'll go for sentence rewrite route. Perhaps let Global Problems template tell the Problems template (using [[Extension:Variables]] "#vardefine:" and "#var:") there are problems under it and use alternate sentence. Or we shouldn't mind about it too much? [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 07:07, 23 November 2016 (CET)
::It should be possible to have the Global Problems template output a variable we can pick up on in the Problems template to account for that. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 09:44, 23 November 2016 (CET)
::: Done. Refer to [[Kirby's Adventure]], [[Super Ghouls 'n Ghosts]] or [[Super Mario RPG: Legend of the Seven Stars]] to see {{tl|Problems}} behavior on different scenarios when used on VC pages. Is there anything else you guys want? - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 16:39, 24 November 2016 (CET)
:::: I'm not comfortable with problem template saying "Excluding Global Problems listed above, ..." because the compatibility rating is supposed to take problems from Global Problems and Problems sections into account and if problem template tells that there are no problems besides global problems, it seems to tell that compatibility rating should do the same. [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 20:32, 24 November 2016 (CET)
::::: Global Problems are (and always were) taken into consideration when assigning a rating, and as I said in the edit summary, the message shown here can be tweaked. BTW, I'm not sure if the issue tracker should be linked here either, AFAIK the devs intentionally made it not too evident (not even the main website links to it after all) - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 00:44, 25 November 2016 (CET)
:::::: I see. The sentence that points to Dolphin's issue tracker was actually just filler to make the section don't look empty. :P I'm not comfortable with it saying something like "excluding Global Problems above". [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 22:52, 25 November 2016 (CET)
:::::: Just noticed the unused parameter "Wikipedia". This has been overlooked when I was copy/pasting from [[Template:Infobox VG]]. I thought I'd like to point that out. Also, would it be better if we renamed the category "Active Problems" to "Ongoing Problems"? [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 00:09, 2 December 2016 (CET)
=== Category Intersection Search ===
it seems that there is no option for searching pages that are a part of two categories or more, at once. if you see the last section of [https://en.wikipedia.org/wiki/Wikipedia:Category_intersection#Tools_currently_available this mediawiki page] then you will find the various options for doing so. however, dolphin wiki's [https://wiki.dolphin-emu.org/index.php?title=Special:Search special:search] page does not work with with, for example:
incategory:Multiplayer_(Game_mode) incategory:Fighting_(Genre)
or even if just using one of the above. so i propose that if fixing that is not simple, that [https://www.mediawiki.org/wiki/Extension:Multi-Category_Search the extension found in the mediawiki article above], is installed. i, personally, would find it extremely useful, and it seems it would take only minutes to install.
[[User:Drmario|Drmario]] ([[User talk:Drmario|talk]]) 17:07, 12 September 2016 (CEST)
: Thanks for the heads-up. Since this is something potentially useful, I requested to one of the guys who maintain the website to install this extension, but he's away and so it will take some days until he can install it to us. In the mean time, I think you can use the [https://www.mediawiki.org/wiki/Extension:DynamicPageList3 DPL3 extension] we have on this wiki to generate a report of pages which intersect as workaround. [[User:Kolano|Kolano]] probably can help you more with its usage (you can also check any of the [[Template:Problems|Problems]] templates for usage examples as they also uses DPL3 extension). - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 21:24, 12 September 2016 (CEST)
:: thank you for the fast reply. i noticed it the next day, but decided i'd see what happens next, as i wasn't sure how simple dynamicpagelist3 would be. but, i tried it today and it's relatively straightforward, but only after having spent 40 minutes with it - i'm not the first person to say the manual is a bit confusing, as it seems it is a very complex extension, with a tonne of options. i added a few much [http://help.gamepedia.com/DPL:Example_-_Select_by_Category simpler examples] to the manual, based on what i wanted to do. but i think other users with the same problem might appreciate the more specific GUI [https://www.mediawiki.org/wiki/Extension:Multi-Category_Search multi-category search] extension on the mediawiki, if they are not as comfortable with wikicode, or if they don't find this 'general discussions' page. provided it doesn't cost much overhead, of course.
:: [[User:Drmario|Drmario]] ([[User talk:Drmario|talk]]) 14:30, 17 September 2016 (CEST)
=== 5.0 announcement ===
* What needs to be done here in context of the Wiki apart from the 'Progress continues' message being updated?
** <s>Updates to the {{tl|Revision}} and {{tl|VersionRevision}} templates. I think most of the baseline stuff is there, but the specific release # to associate with 5.0 still needs to be set, and some other tweaks may be needed.</s> (done, I think)
** <s>Purging of [[:Category:Pages_with_fixed_problems|4.0 resolved issues]]</s> (done)
* Feature differences between 4.0 stable and 5.0 that might require some page updates
** There should be few, if any, of these as we have accounted for development releases throughout the 4.0 cycle.
5.0 Release time is basically... right now! Me and JMC are busy getting everything ready on the blog side. Someone else will need to get things ready here. The current goal is Sunday, and all signs are pointing to us making it, so we don't have a lot of time! - [[User:MaJoR|MaJoR]] ([[User talk:MaJoR|talk]]) 22:07, 14 June 2016 (CEST)
:Oh, one minor note. About issues that can still happen when opening the graphics configuration menu - I'd really like for them to stay. Right now some are marked as fixed and others are not, so if we purge all fixed issues right now it will be a mess... What do you guys think we should do we these? Precedent is all over the place right now! - [[User:MaJoR|MaJoR]] ([[User talk:MaJoR|talk]]) 22:10, 14 June 2016 (CEST)
:So, what's the plan? Wait until 5.0 is out officially to start purging <s>crossed</s> entries? Or start right now? I have some free time during this week, so I can help with the purging... - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 05:05, 15 June 2016 (CEST)
::Weren't we going to automate it? - [[User:MaJoR|MaJoR]] ([[User talk:MaJoR|talk]]) 07:11, 15 June 2016 (CEST)
:::Since we isolated crossed entries on a separate category, I'm pretty sure we can do that with some RegExp trickery. But then, some issues that can still happen when opening the graphics configuration window would be purged too (the ones that were crossed). If we're really going to automate it, we should go through the pages manually to check that case you noted before starting... - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 08:57, 15 June 2016 (CEST)
::::Yea, probably best to do it manually so we can check and make sure everything is correct... Or should I say, you should do it, I'm too busy! :P - [[User:MaJoR|MaJoR]] ([[User talk:MaJoR|talk]]) 04:58, 16 June 2016 (CEST)
: I have a big deliverable on a work project on the 20th, so I won't have much time here. Regarding the graphics options issue, I'd kind of prefer to just purge them and then come back with a generic "Opening Config Can Cause Issues" statement on every game that has an INI file. The current coverage seems pretty scattershot. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 05:13, 16 June 2016 (CEST)
::Wouldn't that be hundreds of games though? By having it in the problem it is much more specific, too. - [[User:MaJoR|MaJoR]] ([[User talk:MaJoR|talk]]) 08:44, 16 June 2016 (CEST)
::: Well, since we're running out of time, I think I can isolate pages from the [[:Category:Pages with fixed problems]] that have references to graphics settings with some special searches. After filtering out those pages we could proceed with the mass purge and decide later what to do on the remaining pages with issues that can still happen when opening the graphics configuration menu. I personally think that moving those problems to Emulation Information may be a good deal (similar to the Bounding Box entries on Paper Mario games -- they are already listed on Emulation Information). What do you think? - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 02:10, 17 June 2016 (CEST)
:::: That works for me! Thank you for doing it! Sorry I can't be of much help, I'm exhausted from all of this 5.0 prep >_< - [[User:MaJoR|MaJoR]] ([[User talk:MaJoR|talk]]) 03:08, 17 June 2016 (CEST)
A quick update: by purging the global problems templates, the number of pages with fixed issues dropped to 275 from the previous 700+ (YAY!). Before filtering the crossed issues related to opening graphics settings, I tried to use RegExp to automatically purge the remaining entries (just a test) and... Database Error. Apparently the RegExp sentence is somehow too complex and we can't proceed. I'll contact Parlane to see if he can do something about that, in the worst scenario I'll start purging manually (fortunately the number of pages with <s>crossed</s> entries isn't that big) - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 07:01, 18 June 2016 (CEST)
:I'm impressed that there is massive drop in number of fixed issues just by purging out from the global problems templates. I may join and do the manual work purging out the fixed problem. [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 07:20, 18 June 2016 (CEST)
::Actually that was expected, as the name implies, those global problems are shown in every single Virtual Console game page. And regarding RegExp issue, Parlane is now aware and will look into it soon... - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 08:27, 18 June 2016 (CEST)
Another quick update: the Replace Text plugin we were using only supported a limited subset of RegExp functions and that's what was causing the problems. After some discussion with Parlane, Replace Text plugin was dropped and now we have [[Special:MassEditRegex|MassEditRegex]] instead (and as usual, only accessible by admins). MassEditRegex doesn't have the limitations from Replace Text and I'm almost ready, I'll probably start the purging later today. Oh, and I almost forgot, edits made through MassEditRegex are marked as bot edits, so they won't spam [[Special:RecentChanges]] unless you explicitly ask it to show bot edits. - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 03:13, 20 June 2016 (CEST)
: Okay, I pressed the red button, mass edits finished and apparently everything went well. There are some pages that used non-standard formatting and thus didn't get caught on the RegExp query or that have issues that can still happen when opening the graphics configuration menu. Since the number of pages needing special treatment seems very small, I'll take care of them manually now, everything regarding page purging should be done very very soon :) - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 04:01, 20 June 2016 (CEST)
:: A bit uncomfortable with the lack of logging for the new-Regex. It's now impossible for anyone but the implementer to review what happened. I have faith in you Jhnonn, but it makes it impossible for others to review/provide assistance, though I guess it's logged on a per-page basis. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 05:32, 20 June 2016 (CEST)
::: The logging is there, but just like the other bots, it's [https://wiki.dolphin-emu.org/index.php?title=Special:RecentChanges&hidebots=0 not shown by default]. If you mean it's not possible to see what RegExp expression was used, we can establish a guideline to include the expression used in the summary field. For keeping record, I used two expressions, on the same query:
::: '''Find:'''
::: <tt>/(?:\={3}\s\{{2}s\}{2}[\s\S]*?\{{2}\/s\}{2}\s\={3})([\s\S]*?(?=\s\=))/</tt>
::: <tt>/(\n{3,})(\n=)/</tt>
:::'''Replace:'''
::: <tt><empty line - placeholder to avoid it being crushed by formatting> </tt>
::: <tt>\n$2</tt>
:::: I see now regarding the logging. The one other feature I'll miss was the ability to use the old plug-in's preview as a general regex search. The new one only provides 20 results, so it's not really effective for that purpose. Ah well. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 00:39, 28 June 2016 (CEST)
:::... which essentially matched every entry in the format <tt>=== <nowiki>{{s}}whatever{{/s}}</nowiki> ===</tt> and then fixed the excess of line breaks left by the first expression. - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 05:54, 20 June 2016 (CEST)
:: Also we shouldn't just transition opening of graphics option issues related to INI conflicts to Emulation Information unedited. We need to indicate the issues now only occur in that case (and only if non-conformant options are set in the graphics config). Would probably be best to set up a new shared Problem template with the general text, that can have specific title issues postfixed to. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 05:38, 20 June 2016 (CEST)
::: For now I'm moving them to Emulation Information and tagging them with [[:Category:5.0 cleanup]] so we can track and make any edits after we discuss how we'll handle those. Also, I'm only moving those entries to emulation information if the game INI already include the settings, otherwise I'm just leaving it in Problems section (uncrossing it if necessary) - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 05:54, 20 June 2016 (CEST)
:::: OK, yeah. Just confirmed on IRC that a merge is expected shortly post-5.0 that should resolve the issue (though I'm unclear on the details). Though it will still be there for 5.0 users it may be best to not worry about it too much. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 05:58, 20 June 2016 (CEST)
I finished the manual review, All pre-5.0 issues were purged from the wiki! At the same time, the number of pages in [[:Category:5.0 cleanup]] is smaller than I thought, so, if possible, please go through the recent edits to see if I didn't let anything slip out of my reviewing. Now it's just a matter of waiting the official 5.0 announcement to then update {{tl|Revision}} and {{tl|VersionRevision}} templates and the notice message at the top of our wiki and we're done! YAY! - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 07:54, 20 June 2016 (CEST)
It's been a while now, have we finished with the review/revision of [[:Category:5.0 cleanup]]? [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 02:46, 20 November 2016 (CET)