|
|
| Line 1: |
Line 1: |
| == Template split ==
| |
| Hadn't time to look into detail before but *why* this template got splitted into two? From the recent discussions it seems that for some games (like King Arthur) the built-in AR switch doesn't work, I got it, but why not edit template logic to conditionally change the text from "Auto" to "Force" if an additional parameter is given? That's waay cleaner than creating an almost identical duplicate to handle this (it's what {{tl|config}} and {{tl|testing}} does to handle channels, for example). I'm completely against having this template split when an super simple addition would achieve the same, I almost reverted it without asking but I think you may have a good reason to do so? - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 05:08, 24 November 2015 (CET)
| |
|
| |
| : It was split for the reason you indicated, the problem text was wrong for a series of titles that instead of "Auto" need to be set to "Force 16:9". Having two templates seemed simpler to me than adding parameters and logic. There are likely to be a few more of these sorts of Problems templates, it seemed like it could get confusing for each to have various sets of parameters. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 08:05, 24 November 2015 (CET)
| |
|
| |
| :: The only two options that can affect native widescreen are "Auto" and "Force 16:9" so we won't need to deal with lots of parameters and right now only two possible games needing "Force 16:9" surfaced, which makes the second template even more redundant. Also, if Dolphin changes something in its settings we would have to modify more templates to account that (not a big deal, but it's more things to keep track). If that's the only reason I'm gonna to merge them back and do something similar to {{tl|config}} and {{tl|testing}}, the logic is veeery simple (a simple <code><nowiki>{{#ifeq:{{{1}}}|force|"Force 16:9"|"Auto"}}</nowiki></code> does the trick) and it defaults to the most used one, so in this case it would be <code><nowiki>{{Problems/WidescreenGCN}}</nowiki></code> for the majority of the titles and <code><nowiki>{{Problems/WidescreenGCN|force}}</nowiki></code> for the two exceptions currently known. - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 17:37, 24 November 2015 (CET)
| |
|
| |
| :::*The one other benefit is being able to get separate lists of the relevant titles. We only generate a single Native Widescreen Support category, so if we don't use different templates there seems to be no easy way to get separate lists.
| |
| :::*There are only those two cases for WidescreenGCN, but there will be other non-widescreen related {{tl|Problems}} templates. It seems like the eventual list of them would be clearer if each didn't have various custom parameters.
| |
| :::*Someone still needs to review all the other titles we list under {{tl|Problems/WidescreenGCNAuto}}, I have a feeling there will be other titles that are also not compatible with Auto AR.
| |
| :::[[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 19:45, 24 November 2015 (CET)
| |
|
| |
| ::::Meh, I'm still not a fan of duplicated templates but you have a good point, keeping the duplicates for now but if I find a way to still get the separate listings without needing a duplicate (or more categories) expect me merging them back into a single one... - [[User:Jhonn|Jhonn]] ([[User talk:Jhonn|talk]]) 03:26, 25 November 2015 (CET)
| |
|
| |
| ::::Completed my testing and didn't find a need for anything but the two options. So it seem like using params is extraneous. [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 11:50, 2 December 2015 (CET)
| |
|
| |
| == Auto vs Forced Review == | | == Auto vs Forced Review == |
| OK, I reviewed all the remaining titles. More titles required Force 16:9 that I had hoped. Please provide commentary below if there is anything further to say here. I don't think there is though, so I plan to purge this discussion out in a few days if there is no further feedback [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 14:42, 2 December 2015 (CET) | | OK, I reviewed all the remaining titles. More titles required Force 16:9 that I had hoped. Please provide commentary below if there is anything further to say here. I don't think there is though, so I plan to purge this discussion out in a few days if there is no further feedback [[User:Kolano|Kolano]] ([[User talk:Kolano|talk]]) 14:42, 2 December 2015 (CET) |
