Template talk:Config: Difference between revisions

Jump to navigation Jump to search
Line 63: Line 63:
Is everything a good addition? I feel they're ready to ship outside the sandbox. [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 03:08, 11 February 2022 (CET)
Is everything a good addition? I feel they're ready to ship outside the sandbox. [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 03:08, 11 February 2022 (CET)
:Will apply changes to outside of the sandbox soon if no one have objection to it. [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 03:20, 14 February 2022 (CET)
:Will apply changes to outside of the sandbox soon if no one have objection to it. [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 03:20, 14 February 2022 (CET)
:: I missed this talk section, sorry. After a brief review, unfortunately I'm against most of the proposed changes:
::: '''• Path to settings:''' makes the output table too crowded and is also redundant (kinda), considering we already group the relevant settings on individual tables (e.g. settings you'll find on the Graphics configuration are on its own table under the Graphics heading and so on).
::: '''• GameINI counterparts:''' suffers from the same issue of making the output table too crowded and can also be a bit confusing in some instances (e.g. keys from different headings grouped in the same table). I don't think the matching INI key is important enough to deserve its own column, especially when we already have the [[GameINI]] page in a featured position (readily accessible from any wiki page via the sidebar link) and also considering we only list settings when they deviate from the defaults (aka it gets wiped from the game page once the built-in GameINI that ships with Dolphin gets updated).
::: '''• Using Template:Config required:''' I see some potential here, but I don't agree with the implementation. Most of the logic of this new sub template is to handle the proposed GameINI column (which I think should be dropped anyway) and from a maintenance perspective I'm definitely not convinced it provides "improved editing performance": the template code is still as complex as before and you now have two different places you'll potentially need to edit in case the template logic needs an update for whatever reason. I do like the input validation via the new category, though, but that can be implemented directly on the main template instead of relying on a sub template.
:: To summarize, I'm supportive of the input validation feature if it gets reworked directly in the main template but the rest is a hard pass from me. - [[User:mbc07|mbc07]] ([[User talk:mbc07|talk]]) 19:12, 14 February 2022 (CET)


== Relabelling Settings ==
== Relabelling Settings ==
Should we relabel settings to reflect current Dolphin UI? Should parameters also follow up? [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 03:08, 11 February 2022 (CET)
Should we relabel settings to reflect current Dolphin UI? Should parameters also follow up? [[User:Lucario|Lucario]] ([[User talk:Lucario|talk]]) 03:08, 11 February 2022 (CET)

Navigation menu